BREAKING CHANGE(web): Enhance custom height and max height options of ModalDialog #DS-1134
#1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani,
curdaj and
a team
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
adamkudrna
force-pushed
the
bc/modal-custom-height
branch
from
b2e7e00
to
6c26337
Compare
adamkudrna
commented
May 16, 2024
adamkudrna
force-pushed
the
bc/modal-custom-height
branch
from
6c26337
to
77229c9
Compare
crishpeen
reviewed
May 18, 2024
crishpeen
reviewed
May 18, 2024
adamkudrna
force-pushed
the
bc/modal-custom-height
branch
from
77229c9
to
cff3169
Compare
adamkudrna
force-pushed
the
bc/modal-scrolling
branch
from
cf7db9c
to
a3c58e1
Compare
adamkudrna
force-pushed
the
bc/modal-custom-height
branch
from
cff3169
to
e17bafb
Compare
adamkudrna
force-pushed
the
bc/modal-scrolling
branch
from
a3c58e1
to
8e277b5
Compare
adamkudrna
force-pushed
the
bc/modal-custom-height
branch
from
e17bafb
to
2b60359
Compare
crishpeen
approved these changes
May 21, 2024
crishpeen
force-pushed
the
bc/modal-custom-height
branch
from
2b60359
to
cae7b7a
Compare
curdaj
approved these changes
May 21, 2024
crishpeen
force-pushed
the
bc/modal-custom-height
branch
from
cae7b7a
to
4583965
Compare
crishpeen
force-pushed
the
integration/release-v2
branch
from
0c51cb5
to
09bff9a
Compare
crishpeen
force-pushed
the
bc/modal-custom-height
branch
2 times, most recently
from
a35f16d
to
d55c1f1
Compare
… `ModalDialog` #DS-1134 1. Custom height and custom max height can be set individually on all breakpoints now. 2. The `--modal-preferred-height-mobile` and `--modal-preferred-height-tablet` custom properties were renamed.
crishpeen
force-pushed
the
bc/modal-custom-height
branch
from
d55c1f1
to
adcc1e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--modal-preferred-height-mobileand--modal-preferred-height-tabletcustom properties were renamed.Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-1134