Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(form-validations): Add missing TypeScript dependency #1427

Merged
merged 1 commit into from
May 20, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented May 20, 2024

Description

The build script was not working due to the missing TypeScript dependency and also due to the single quotes ('...').

Additional context

Issue reference

@literat literat requested review from pavelklibani, curdaj and a team as code owners May 20, 2024 11:42
@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label May 20, 2024
Copy link

netlify bot commented May 20, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 1ef97d9
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/664b37131dc5fe0009a96bf8

Copy link

netlify bot commented May 20, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 1ef97d9
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/664b37131adc340008df6f6f
😎 Deploy Preview https://deploy-preview-1427--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 79.544% (-17.4%) from 96.911%
when pulling 1ef97d9 on chore/missing-dependency
into 4466192 on main.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 79.544% (-17.4%) from 96.911%
when pulling 1ef97d9 on chore/missing-dependency
into 4466192 on main.

@coveralls
Copy link

Coverage Status

coverage: 79.544% (-17.4%) from 96.911%
when pulling 1ef97d9 on chore/missing-dependency
into 4466192 on main.

@literat literat merged commit 71948ef into main May 20, 2024
15 checks passed
@literat literat deleted the chore/missing-dependency branch May 20, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants