Require PHPUnit ^8.5.12 (part of #260)

lmc-eu · Mar 7, 2021 · 366c0c9 · 366c0c9
1 parent 10cc2b6
commit 366c0c9
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,8 +8,8 @@
 - Show test duration in timeline tooltips.
 
 ### Changed
-- Require PHP 7.3+ and Symfony 4 components.
-- Update to namespaced PHPUnit 7.0.
+- Require PHP 7.3+ and Symfony 5 components.
+- Update to namespaced PHPUnit. Set minimal required version to PHPUnit 8.5.12.
 - Use php-webdriver 1.8+ with W3C WebDriver support.
 - Methods now uses strict type-hints and return type-hints. Inherited classes and interfaces (eg. `CustomCapabilitiesResolverInterface`, `OptimizeOrderInterface` etc.) may require to be changed in accordance with this.
 - Simplified and improved test output.

diff --git a/composer.json b/composer.json
@@ -35,7 +35,7 @@
         "ondram/ci-detector": "^4.0",
         "php-webdriver/webdriver": "^1.10.0",
         "phpdocumentor/reflection-docblock": "^5.2",
-        "phpunit/phpunit": "^7.5.20",
+        "phpunit/phpunit": "^8.5.12",
         "roave/better-reflection": "^4.3",
         "symfony/console": "^5.2",
         "symfony/event-dispatcher": "^5.2",
@@ -55,7 +55,6 @@
         "phpstan/extension-installer": "^1.1",
         "phpstan/phpstan": "^0.12.80",
         "phpstan/phpstan-phpunit": "^0.12.17",
-        "phpunit/php-code-coverage": "^6.1",
         "symfony/var-dumper": "^5.2"
     },
     "suggest": {

diff --git a/src-tests/Console/Command/RunCommandTest.php b/src-tests/Console/Command/RunCommandTest.php
@@ -408,7 +408,7 @@ protected function getSeleniumAdapterMock()
 
         $seleniumAdapterMock->expects($this->any())
             ->method('getLastError')
-            ->willReturn(null);
+            ->willReturn('');
 
         $seleniumAdapterMock->expects($this->any())
             ->method('isSeleniumServer')

diff --git a/src-tests/Listener/SnapshotListenerTest.php b/src-tests/Listener/SnapshotListenerTest.php
@@ -111,7 +111,7 @@ public function provideTestWithDataSet(): array
                 $dummyException,
                 'FooBarTest',
                 'testFooBar',
-                0,
+                '0',
                 ['foo', 'bar'],
                 'FooBarTest-testFooBar-with-data-set-0',
             ],

diff --git a/src-tests/MockAbstractTestCaseWithNameTrait.php b/src-tests/MockAbstractTestCaseWithNameTrait.php
@@ -3,8 +3,8 @@
 namespace Lmc\Steward;
 
 use Lmc\Steward\Test\AbstractTestCase;
-use PHPUnit\Framework\MockObject\Matcher\AnyInvokedCount;
 use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\MockObject\Rule\AnyInvokedCount;
 
 trait MockAbstractTestCaseWithNameTrait
 {

diff --git a/src-tests/Selenium/CapabilitiesResolverTest.php b/src-tests/Selenium/CapabilitiesResolverTest.php
@@ -78,7 +78,7 @@ public function testShouldResolveExtraDesiredCapabilitiesOnCiServer(): void
             ]
         );
 
-        $ciMock = $this->createConfiguredMock(Jenkins::class, ['getBuildNumber' => 1337, 'getCiName' => 'Jenkins']);
+        $ciMock = $this->createConfiguredMock(Jenkins::class, ['getBuildNumber' => '1337', 'getCiName' => 'Jenkins']);
         $ciDetectorMock = $this->createConfiguredMock(
             CiDetector::class,
             ['isCiDetected' => true, 'detect' => $ciMock]