Add parallel limit #225
Merged
Add parallel limit #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndraM
force-pushed
the
feature/parallel-limit
branch
from
853956e
to
1d0bf74
Compare
jirinovak
reviewed
Oct 29, 2018
|
|
||
| protected function parallelLimitReached(): bool | ||
| { | ||
| return count($this->processSet->get(ProcessWrapper::PROCESS_STATUS_PREPARED)) >= $this->parallelLimit; |
There was a problem hiding this comment.
This is strange, isn`t it?
How current number of processes be greater than limit?
There was a problem hiding this comment.
Well, this is parallelism, who knows what could happen 🤣 . I prefer being a bit defensive there.
OndraM
force-pushed
the
feature/parallel-limit
branch
3 times, most recently
from
12227c8
to
2df6ad9
Compare
…n log and never finished tests This is caused by sebastianbergmann/phpunit#3379
OndraM
force-pushed
the
feature/parallel-limit
branch
from
ffc04cc
to
a2939c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #210, #153
Allow to define a parallel limit (by default 50) - the actual number of parallel processes started by Steward.
Current theory of operation was:
But this started causing issues on large testsuites (with hundreds of tests), because, obviously, there has been running system process (consuming RAM, CPU) for each testcase, even if most of them were just queued and were just waiting for free slot. And with Selenium farm, which is capable of running many tests in a parallel, this could easily lead to uncontrolled resources exhausting.
The new theory operation is:
Note the PR is still kind-of proof of concept, I expect some beta-testing of this branch (and maybe some code cleanup) before this will be merged to master.