Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 + fix builds #305

Merged
merged 2 commits into from Jan 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/tests.yaml
Expand Up @@ -13,15 +13,15 @@ jobs:

strategy:
matrix:
php-version: ['7.3', '7.4', '8.0', '8.1', '8.2']
php-version: ['7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
dependencies: ['']
include:
- { php-version: '7.3', dependencies: '--prefer-lowest --prefer-stable' }

name: Unit tests - PHP ${{ matrix.php-version }} ${{ matrix.dependencies }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
name: Integration tests (Selenium ${{ matrix.selenium-version }})

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
name: "Code style and static analysis"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand All @@ -139,7 +139,7 @@ jobs:
name: "Markdown link check"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
use-verbose-mode: 'yes'
Expand Down
2 changes: 1 addition & 1 deletion src-tests/Component/Fixtures/simple.legacy
@@ -1 +1 @@
a:2:{s:3:"foo";s:3:"bar";s:3:"baz";s:3:"ban";}
a:2:{s:3:"foo";s:3:"bar";s:3:"baz";s:3:"ban";}
Expand Up @@ -23,7 +23,6 @@ public function testShouldConfigureGivenOptionsResolver(): void

$configurator->configure($optionsResolver);

/** @phpstan-ignore-next-line */
$this->assertNotEmpty($optionsResolver->getDefinedOptions());
}

Expand Down