Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knob for tweaking maximum random projection tree depth #229

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Knob for tweaking maximum random projection tree depth #229

merged 4 commits into from
Nov 9, 2023

Conversation

hamelin
Copy link
Contributor

@hamelin hamelin commented Nov 9, 2023

No description provided.

lmcinnes
lmcinnes requested changes Nov 9, 2023
View reviewed changes
Copy link
Owner

@lmcinnes lmcinnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change in the docstring to be clearer, and upping the default max tree depth to 200, which should help avoid some issues.

pynndescent/pynndescent_.py Outdated Show resolved Hide resolved
pynndescent/pynndescent_.py Show resolved Hide resolved
pynndescent/pynndescent_.py Outdated Show resolved Hide resolved
pynndescent/rp_trees.py Outdated Show resolved Hide resolved
pynndescent/rp_trees.py Outdated Show resolved Hide resolved
pynndescent/rp_trees.py Outdated Show resolved Hide resolved
@lmcinnes lmcinnes merged commit eee705a into lmcinnes:master Nov 9, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmcinnes lmcinnes lmcinnes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hamelin @lmcinnes