Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests should run w/o conda also #30

Merged
merged 4 commits into from Nov 30, 2017

Conversation

sauln
Copy link
Collaborator

@sauln sauln commented Nov 30, 2017

It looks like the travis-ci tests only run on conda distributions. UMAP should be able to run without conda just fine.

This is a work in progress. I'm having trouble getting travis to work correctly and am not sure any better way to test it except pushing amendments to the commits.

@pep8speaks
Copy link

pep8speaks commented Nov 30, 2017

Hello @sauln! Thanks for updating the PR.

Line 52:34: E128 continuation line under-indented for visual indent
Line 103:48: E127 continuation line over-indented for visual indent
Line 105:1: E302 expected 2 blank lines, found 1
Line 123:80: E501 line too long (82 > 79 characters)
Line 132:80: E501 line too long (80 > 79 characters)
Line 136:1: E302 expected 2 blank lines, found 1
Line 144:80: E501 line too long (80 > 79 characters)
Line 145:37: E127 continuation line over-indented for visual indent
Line 146:41: E127 continuation line over-indented for visual indent
Line 155:37: E127 continuation line over-indented for visual indent
Line 156:41: E127 continuation line over-indented for visual indent
Line 161:1: E302 expected 2 blank lines, found 1
Line 177:29: E127 continuation line over-indented for visual indent
Line 185:29: E127 continuation line over-indented for visual indent
Line 195:1: E302 expected 2 blank lines, found 1
Line 201:5: E265 block comment should start with '# '
Line 206:80: E501 line too long (80 > 79 characters)

Comment last updated on November 30, 2017 at 17:32 Hours UTC

@sauln sauln force-pushed the integration branch 2 times, most recently from 0eeb3d6 to be28344 Compare November 30, 2017 08:28
@lmcinnes
Copy link
Owner

I agree, but clearly your travis-fu is better than mine; I simply worked from available templates. Anything you can do here is greatly appreciated.

@sauln sauln force-pushed the integration branch 2 times, most recently from 2aaf5a6 to c05a8ec Compare November 30, 2017 17:48
@sauln sauln merged commit fe6c8c5 into lmcinnes:master Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants