Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metric option precomputed (#26) #31

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Conversation

LGro
Copy link
Contributor

@LGro LGro commented Dec 1, 2017

I'm not sure why the metric validation in umap_.py:1308-1314 was commented out by you in da04e17, but in case you want to integrate this again, you would need to add the following:

elif metric == 'precomputed':
    pass

@pep8speaks
Copy link

Hello @LGro! Thanks for submitting the PR.

Line 191:80: E501 line too long (80 > 79 characters)
Line 305:80: E501 line too long (80 > 79 characters)
Line 374:80: E501 line too long (80 > 79 characters)
Line 443:80: E501 line too long (80 > 79 characters)
Line 647:38: E231 missing whitespace after ','
Line 650:46: E231 missing whitespace after ','
Line 664:37: E127 continuation line over-indented for visual indent
Line 673:33: E128 continuation line under-indented for visual indent
Line 677:41: E128 continuation line under-indented for visual indent
Line 678:41: E128 continuation line under-indented for visual indent
Line 680:53: E128 continuation line under-indented for visual indent
Line 681:53: E128 continuation line under-indented for visual indent
Line 682:53: E128 continuation line under-indented for visual indent
Line 683:53: E128 continuation line under-indented for visual indent
Line 684:53: E128 continuation line under-indented for visual indent
Line 685:53: E128 continuation line under-indented for visual indent
Line 686:53: E128 continuation line under-indented for visual indent
Line 687:53: E128 continuation line under-indented for visual indent
Line 688:53: E128 continuation line under-indented for visual indent
Line 693:41: E128 continuation line under-indented for visual indent
Line 694:41: E128 continuation line under-indented for visual indent
Line 696:53: E128 continuation line under-indented for visual indent
Line 697:53: E128 continuation line under-indented for visual indent
Line 698:53: E128 continuation line under-indented for visual indent
Line 699:53: E128 continuation line under-indented for visual indent
Line 700:53: E128 continuation line under-indented for visual indent
Line 701:53: E128 continuation line under-indented for visual indent
Line 706:17: E128 continuation line under-indented for visual indent
Line 707:17: E128 continuation line under-indented for visual indent
Line 857:5: E741 ambiguous variable name 'I'
Line 875:80: E501 line too long (80 > 79 characters)
Line 1119:80: E501 line too long (80 > 79 characters)
Line 1120:9: E722 do not use bare except'
Line 1241:80: E501 line too long (80 > 79 characters)
Line 1267:80: E501 line too long (80 > 79 characters)

@LGro LGro changed the title add metric option precomputed (#24) add metric option precomputed (#26) Dec 1, 2017
@LGro
Copy link
Contributor Author

LGro commented Dec 1, 2017

Sorry for falsely referencing #24 instead of #26 in the commit.

@lmcinnes
Copy link
Owner

lmcinnes commented Dec 1, 2017

Looks great! Thanks for taking the time to do this, it is greatly appreciated. If you have any further ideas for improvements please don't hesitate to propose them. I'll gladly accept more pull requests like this.

@lmcinnes lmcinnes merged commit a0c424c into lmcinnes:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants