Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update penguins doc #914

Merged
merged 6 commits into from Sep 19, 2022
Merged

Update penguins doc #914

merged 6 commits into from Sep 19, 2022

Conversation

jlmelville
Copy link
Collaborator

Striking while the doc-build iron is hot, this PR:

  • updates some URLs that had got stale. In particular, the URL for the penguin image, but also the CSV file itself.
  • the URLs are now github permalinks, so hopefully even if future breaking changes occur, these particularly URLs will stay valid.
  • updates to the penguin dataset meant that:
    • there are now a different number of non-NA rows.
    • also the column names had changed slightly.
    • and there was a year column added.
  • the text has been adjusted to reflect the above and I drop the year column in the pairplot.
    • I had to regenerate the pairplot. It has larger dimensions (not sure how to change that via jupyter lab) but is otherwise quite similar.
  • also to be on the safe side I regenerated the UMAP plot (it doesn't change much, reassuringly).
  • one change to the digits example: there was a minor change to the PIL API.

@jlmelville
Copy link
Collaborator Author

how did I break all the builds with this change? 🤔

@lmcinnes
Copy link
Owner

The breakage is, I think, my fault. Don't worry about it for now.

@lmcinnes lmcinnes merged commit 544dbe9 into lmcinnes:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants