Fix bug when reading sequence names without whitespace, adding tests #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for writing such great software, Lianming! I really appreciate it.
I've attempted to fix that bug I reported and wrote a test to catch it. Some edits to the documentation are also included.
While mucking around with pyfastx I also noticed that the
key_func
feature may not be working as expected, but I may be mis-interpreting how it works exactly. Anyway, I wrote a test forkey_func
that checks whether the new identifiers (presumably stored as the 'name' attribute?) match a specific prefix ('contig') when parsing the FASTA filetest.fa
. This test is currently failing because it appears to me that no Sequence attributes are modified according tokey_func
.Lastly, I included a few functions in
tests/testing_utils.py
to make retrieving test data more straightforward.Thanks again!