Params eval #550
Merged
Params eval #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
==========================================
+ Coverage 83.28% 86.21% +2.93%
==========================================
Files 11 11
Lines 3170 3875 +705
==========================================
+ Hits 2640 3341 +701
- Misses 530 534 +4
Continue to review full report at Codecov.
|
|
@zobristnicholas Thanks! That looks good to me. Does anyone have an objection to merging this? |
reneeotten
requested changes
Apr 30, 2019
zobristnicholas
force-pushed
the
params-eval
branch
from
3efe5a0
to
2a728bf
Compare
reneeotten
approved these changes
Apr 30, 2019
|
the Travis failure is unrelated and due to a flaky test... I have changed it already in the other PR. @newville can I merge this one? |
|
@reneeotten yes, please merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is in reference to the discussion here: https://groups.google.com/forum/#!topic/lmfit-py/pJWdxzYRGqI
Expressions derived from parameter values are often added to a Parameters() object using params.add("name", expr="expression"). These expressions can contain common numpy functions, user-defined functions, and parameter values. During a fit, they are evaluated every iteration.
If this updating behavior is not desired, an expression can be evaluated post-fitting using the parameter values directly using p = params.valuesdict(). However, there is currently no public method to retrieve user-defined symbols from the object.
This PR addresses this point by allowing the user to evaluate arbitrary expressions in the Parameters object's namespace via the params.eval() method. A test for this method is also included.
Type of Changes
Tested on
Python: 3.7.3 (default, Mar 27 2019, 16:54:48)
[Clang 4.0.1 (tags/RELEASE_401/final)]
lmfit: 0.9.13+7.gbcec209, scipy: 1.2.1, numpy: 1.16.3, asteval: 0.9.13, uncertainties: 3.0.3, six: 1.12.0
Verification
Not sure the best way to do these two