Prevent double clicks when signing contracts; Don't explode on double clicks #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProtoJoe
reviewed
Jun 13, 2018
| @@ -16,7 +16,7 @@ Gem::Specification.new do |s| | |||
| s.files = Dir['{app,config,db,lib}/**/*'] + ['MIT-LICENSE', 'Rakefile', 'README.md'] | |||
| s.test_files = Dir['spec/**/*'] | |||
|
|
|||
| s.add_dependency 'rails', '>= 3.1' | |||
| s.add_dependency 'rails', '>= 3.1', '< 5.0' | |||
There was a problem hiding this comment.
What's the reasoning for restricting Rails to < 5?
There was a problem hiding this comment.
@Dantemss I have just answered my own question by looking at the commit messages... my question may be ignored. However!!! If you look at the PR I submitted (#24), I migrated away from Squeel to BabySqueel, which is supported in Rails > 5, so the Rails restriction can be removed if my PR is merged. Thoughts?
There was a problem hiding this comment.
I will rebase and merge after merging yours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.