Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Relax dependencies for sqlalchemy and pandas and drop python 3.7 #103

Merged
merged 3 commits into from Apr 6, 2023
Merged

[MNT] Relax dependencies for sqlalchemy and pandas and drop python 3.7 #103

merged 3 commits into from Apr 6, 2023

Conversation

lmmentel
Copy link
Owner

@lmmentel lmmentel commented Apr 5, 2023 •
edited

  • drop python 3.7
  • relax sqlalchemy version and drop python 3.7

closes #95

@lmmentel lmmentel changed the title [MNT] Realx dependency version and drop python 3.7 [MNT] Relax dependencies for sqlalchemy and pandas and drop python 3.7 Apr 5, 2023
@lmmentel lmmentel self-assigned this Apr 5, 2023
@lmmentel lmmentel added dependencies Pull requests that update a dependency file maintenance labels Apr 5, 2023
@lmmentel lmmentel marked this pull request as ready for review April 5, 2023 22:22
@lmmentel lmmentel merged commit b125548 into master Apr 6, 2023
17 checks passed
@lmmentel lmmentel deleted the mnt/bump-sqlalchemy branch April 6, 2023 13:14
@jan-janssen
Copy link

@lmmentel Can you release a new version which includes this fix?

jan-janssen
jan-janssen reviewed Apr 8, 2023
View reviewed changes
pyproject.toml
colorama = "^0.4.4"
numpy = "^1.21"
pyfiglet = "^0.8.post1"
Pygments = "^2.8.0"
pandas = ">=0.25.0"
pandas = ">=1.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit surprised. Is pandas==1.0.0 really sufficient or are the recent changes of 2.0.0 required? I thought we were waiting for 2.0.0 all the time.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pandas 0.25 dates back to 2019 and there have been many breaking api changes along the way. Nothing directly impacting this packages afaik but I don't want to lag too much behind allowing for weird issues to come up.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree but I thought you would need pandas >=2.0.0 to be compatible with the latest sqlalchemy version.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that sqlalchemy is now compatible with pandas 2.0.0 and older versions. I've tested both cases and it seems to work so it makes sense to keep some flexibility in versions.

@lmmentel
Copy link
Owner Author

lmmentel commented Apr 8, 2023

@lmmentel Can you release a new version which includes this fix?

Yup, that's the plan, but I would like to wait until I have some feedback on #105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen left review comments

Assignees

@lmmentel lmmentel

Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does Mendeleev support SQLAlchemy=2.0.0 ?
2 participants
@lmmentel @jan-janssen