Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Course date filtering #42aeqw #11

Merged
merged 11 commits into from Feb 26, 2020

Conversation

jcoryalvernaz
Copy link
Contributor

@jcoryalvernaz jcoryalvernaz commented Feb 2, 2020

Overview

Add functionality to allow users to filter courses based on a selected date filter.

Details

  • Install date-fns library to more easily deal with date arithmetic.
  • Populate the drop down list for date filter to only show date ranges that are available.
  • Update the displayed courses to reflect the selection of the date filter.
  • Make sure the drop down list is sorted in correct order (i.e This Month, Next Month, Next Six Months, Next Year)
  • Update the URL query parameters to reflect the selected date filter.

Bonus

  • Fixed a bug in age filtering where courses for age < 5 were not being shown.
  • Pass in courses filtered by only geo location and category to the age, date, and course filters. (This fix makes it so drop down lists don't inadvertently get filtered based on what courses are visible)

QA Instructions

  • Visit the programs page on the Playwell staging site.
  • Enter in a location.
  • Selecting an age filter from the drop down should update the label of the drop down.
  • Selecting a date filter from the drop down should update the label of the drop down.
  • Selecting a date filter from the drop down should update the list of courses for that date range.
  • Selecting a date filter from the drop down should update the course counters below the drop down.
  • Selecting a date filter from the drop down should update the url with the query parameters for date_min and date_max

#42aeqw

@jrossm
Copy link

jrossm commented Feb 25, 2020

QA Pass -- location filters, dropdown labels and url params work as expected! 🎇

@jcoryalvernaz jcoryalvernaz force-pushed the ja/feature--course-date-filtering--42aeqw branch from a57111f to a1e3212 Compare February 26, 2020 18:25
@jrossm
Copy link

jrossm commented Feb 26, 2020

QA round 2 passed! 🗻

Copy link
Collaborator

@elskwid elskwid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We're going to clean up the formatting on these files after the third PR lands.

@elskwid elskwid merged commit 6232669 into master Feb 26, 2020
@elskwid elskwid deleted the ja/feature--course-date-filtering--42aeqw branch February 26, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants