Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jade Cleanup #26

Open
rtoal opened this issue Nov 21, 2011 · 0 comments
Open

Jade Cleanup #26

rtoal opened this issue Nov 21, 2011 · 0 comments
Assignees

Comments

@rtoal
Copy link
Collaborator

rtoal commented Nov 21, 2011

The jade templates should be cleaned up before we do any work on professional styling.

  1. In the HTML5 <script> tag, the type attribute defaults to "text/javascript" so type attributes should be removed.
  2. In the HTML5 <link> tag, when rel is stylesheet, the type attribute defaults to "text/css" so type attributes should be removed.
  3. I see css ids and classnames like button-upper-right and topLeftMargin. Those are SOOO not class names! Do not ever hint at something positional in a class name. Give then semantic names.
  4. Note also in item 3 above, am I to assume you went with dashes in names for ids and camel case for classes? Is there a reason for that choice or did you not notice the inconsistency?
  5. zombieTest.jade is obsolete and should be removed.
@ghost ghost assigned rowedonalde Nov 21, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants