Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from ecdsa and secp256k1 to coincurve #45

Closed
prusnak opened this issue Jul 17, 2024 · 3 comments
Closed

migrate from ecdsa and secp256k1 to coincurve #45

prusnak opened this issue Jul 17, 2024 · 3 comments

Comments

@prusnak
Copy link

prusnak commented Jul 17, 2024

i think we should just migrate to coincurve - it is well maintained (last secp256k1 release was in 2021) - and even CLN uses coincurve and not secp256k1 for their python plugins

it would be great to also drop the ecdsa dependency and use only coincurve

@michael1011
Copy link
Contributor

I've never been a fan of this library coming with a signature library by default. How about switching to coincurve and making it optional?

@prusnak
Copy link
Author

prusnak commented Jul 17, 2024

I want to reduce the number of libraries used by lnbits, not to increase it.

Now I understand it better what you meant. Yes, makes sense! 👍

@prusnak
Copy link
Author

prusnak commented Jul 19, 2024

Done in #46 and released via 2.1.0

@prusnak prusnak closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants