Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Extension: NIP-05 Verification #1225

Merged
merged 20 commits into from Dec 29, 2022
Merged

New Extension: NIP-05 Verification #1225

merged 20 commits into from Dec 29, 2022

Conversation

leesalminen
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #1225 (4ab5285) into main (49e722d) will decrease coverage by 0.09%.
The diff coverage is 48.93%.

@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
- Coverage   49.87%   49.77%   -0.10%     
==========================================
  Files         255      262       +7     
  Lines       14721    15055     +334     
==========================================
+ Hits         7342     7494     +152     
- Misses       7379     7561     +182     
Impacted Files Coverage Δ
lnbits/extensions/nostrnip5/crud.py 28.81% <28.81%> (ø)
lnbits/extensions/nostrnip5/views_api.py 33.04% <33.04%> (ø)
lnbits/extensions/nostrnip5/tasks.py 52.38% <52.38%> (ø)
lnbits/extensions/nostrnip5/views.py 60.00% <60.00%> (ø)
lnbits/extensions/nostrnip5/__init__.py 94.11% <94.11%> (ø)
lnbits/extensions/nostrnip5/models.py 94.59% <94.59%> (ø)
lnbits/extensions/nostrnip5/migrations.py 100.00% <100.00%> (ø)
lnbits/extensions/satspay/views_api.py 38.55% <0.00%> (-1.96%) ⬇️
lnbits/core/crud.py 57.29% <0.00%> (-1.95%) ⬇️
lnbits/extensions/lnurldevice/crud.py 31.81% <0.00%> (-1.52%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@leesalminen leesalminen marked this pull request as ready for review December 21, 2022 20:34
@leesalminen
Copy link
Contributor Author

Have 50+ verified users using this extension. Think it's good to go.

@callebtc callebtc added the extension proposal New extension proposal label Dec 26, 2022
@callebtc
Copy link
Collaborator

Awesome work! Could you run make format once?

@arcbtc
Copy link
Member

arcbtc commented Dec 29, 2022

Wow, cool! I could use for nostr.com. Will test today and do the make formatting etc

@arcbtc
Copy link
Member

arcbtc commented Dec 29, 2022

Worked great! LGTM

@arcbtc arcbtc merged commit b1e0874 into lnbits:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension proposal New extension proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants