Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Example Great Again #1321

Merged
merged 9 commits into from
Jan 6, 2023
Merged

Make Example Great Again #1321

merged 9 commits into from
Jan 6, 2023

Conversation

arcbtc
Copy link
Member

@arcbtc arcbtc commented Jan 6, 2023

resurrecting the Example extension, so we can add guides and examples for extension developers

@arcbtc arcbtc added the extension Extensions for LNbits label Jan 6, 2023
@arcbtc arcbtc marked this pull request as draft January 6, 2023 10:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #1321 (e7c479f) into main (7cfbb92) will increase coverage by 0.05%.
The diff coverage is 62.96%.

@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
+ Coverage   48.30%   48.35%   +0.05%     
==========================================
  Files         278      282       +4     
  Lines       16295    16348      +53     
==========================================
+ Hits         7871     7905      +34     
- Misses       8424     8443      +19     
Impacted Files Coverage Δ
lnbits/extensions/example/tasks.py 50.00% <50.00%> (ø)
lnbits/extensions/example/views_api.py 75.00% <66.66%> (ø)
lnbits/extensions/example/__init__.py 82.35% <80.00%> (ø)
lnbits/extensions/boltcards/views_api.py 22.47% <0.00%> (-0.79%) ⬇️
lnbits/extensions/example/views.py 90.00% <0.00%> (ø)
lnbits/wallets/spark.py 16.42% <0.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@callebtc
Copy link
Collaborator

callebtc commented Jan 6, 2023

MEGA

@arcbtc arcbtc marked this pull request as ready for review January 6, 2023 11:06
@arcbtc
Copy link
Member Author

arcbtc commented Jan 6, 2023

this is actually mergable as is, but I will add some bits first

@arcbtc arcbtc merged commit 4f4a578 into main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Extensions for LNbits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants