-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merges extensions into one page #1656
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1656 +/- ##
==========================================
+ Coverage 48.43% 48.81% +0.38%
==========================================
Files 47 47
Lines 7047 7092 +45
==========================================
+ Hits 3413 3462 +49
+ Misses 3634 3630 -4
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
></q-btn> | ||
</p> | ||
<div class="col-sm-9 col-xs-12"> | ||
<p class="text-h4 gt-sm">Extensions</p> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Just checked and this is a different bug, for some reason descriptions are missing for some extensions |
e10c857
to
d23f66f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as duplicate.
This comment was marked as duplicate.
Co-authored-by: dni ⚡ <office@dnilabs.com>
@arbadacarbaYK thanks for the input. This is a pretty big change (UI wise). It can be discussed in a different PR/issue. (not included in this PR) |
Gets rid of "Manage Extensions" page and merges into "Extensions"
Check admin here https://extdemo.satoshigo.app/extensions?usr=2f1c28dd6ce44f7884edde1c8269b3c1
Extra
Manage Extensions
intoExtensions
"min_lnbits_version"
. And for release warning:warning
in
extensions.json
or in
config.json
:show error message on the UI
show warning message on the UI
show
New Version
when a new version is availablei18n
text inextensions.html
Tests
min_lnbits_version
to a future LNbits version will not allow the installationextension.json
example [here] (https://github.com/motorina0/lnbits-extensions/blob/main/extensions.json#L355)config.json
(GitHub release) example hereRaw
pathmin_lnbits_version
to a lower version (or empty) must allow the installwarning
field in the extensions.json or in the config.json will show the when the release is expandedNew Version
badge is displayed