Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extensions dir completly, create it on startup #1778

Merged
merged 2 commits into from Jul 18, 2023
Merged

Conversation

dni
Copy link
Member

@dni dni commented Jun 22, 2023

like we did for the data dir.
tested works great.
so no more unstaged git files when you are symlinking into your own extensions dir.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Merging #1778 (c82aca5) into main (7e1f439) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head c82aca5 differs from pull request most recent head d68245c. Consider uploading reports for the commit d68245c to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1778      +/-   ##
==========================================
- Coverage   55.44%   55.44%   -0.01%     
==========================================
  Files          47       47              
  Lines        7250     7251       +1     
==========================================
  Hits         4020     4020              
- Misses       3230     3231       +1     
Impacted Files Coverage Δ
lnbits/server.py 43.90% <0.00%> (-1.10%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dni dni added this to the Release Version 0.10.10 milestone Jun 22, 2023
@dni dni changed the title remove extensions dir compleltly, and create it on server.py start remove extensions dir completly, create it on startup Jun 25, 2023
@callebtc callebtc merged commit 153e22f into main Jul 18, 2023
25 checks passed
@callebtc callebtc deleted the remove-ext-dir branch July 18, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants