refactor exchange rates #1847
Merged
refactor exchange rates #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1847 +/- ##
==========================================
+ Coverage 56.12% 56.30% +0.17%
==========================================
Files 48 48
Lines 7323 7309 -14
==========================================
+ Hits 4110 4115 +5
+ Misses 3213 3194 -19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jackstar12
force-pushed
the
refactor-exchange-rates
branch
3 times, most recently
from
61af150
to
fb6a4b7
Compare
dni
force-pushed
the
refactor-exchange-rates
branch
2 times, most recently
from
f86e318
to
7f3c9f7
Compare
arcbtc
approved these changes
Aug 24, 2023
jackstar12
force-pushed
the
refactor-exchange-rates
branch
from
203841f
to
6638b29
Compare
dni
approved these changes
Aug 24, 2023
note that exir was removed as a provider
dni
force-pushed
the
refactor-exchange-rates
branch
from
6638b29
to
6b33ea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplifies the code and adds caching.
the the
return_exceptionson thegatheris key as it tells gather not to return if one of the tasks fail but instead wait for all to complete.Exir was removed as a provider because it doesnt work (maybe binance alternative?)