[REFACTOR] proper create_invoice responses for descriptions #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1863 +/- ##
==========================================
- Coverage 56.35% 55.30% -1.05%
==========================================
Files 49 49
Lines 7529 7534 +5
==========================================
- Hits 4243 4167 -76
- Misses 3286 3367 +81
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
motorina0
reviewed
Aug 14, 2023
dni
force-pushed
the
refactor-create-invoice
branch
2 times, most recently
from
81ef58d
to
807cf13
Compare
dni
force-pushed
the
refactor-create-invoice
branch
from
807cf13
to
897ec04
Compare
michael1011
reviewed
Aug 23, 2023
dni
force-pushed
the
refactor-create-invoice
branch
from
d6d48d3
to
81a5fc6
Compare
dni
force-pushed
the
refactor-create-invoice
branch
from
81a5fc6
to
a72f7fe
Compare
arcbtc
approved these changes
Aug 24, 2023
jackstar12
approved these changes
Aug 24, 2023
return a exception per error it is description hash or unhashed_description keep types
Co-authored-by: michael1011 <me@michael1011.at>
Co-authored-by: michael1011 <me@michael1011.at>
dni
force-pushed
the
refactor-create-invoice
branch
from
a72f7fe
to
aca1d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return a exception per error it is description hash or unhashed_description