Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] improve on github workflows #1889

Merged
merged 2 commits into from Aug 24, 2023
Merged

[CI] improve on github workflows #1889

merged 2 commits into from Aug 24, 2023

Conversation

dni
Copy link
Member

@dni dni commented Aug 20, 2023

Refactor if LNbits CI.
remove code duplication and make it more flexible to orchestrate and maintain.

took 5m30-6m as all grouped
before it took about 4m30-5m30 for the last regtest to finish, but there is no measurement how long it took for them together.

after caching npm i brought it down to 4m30 https://github.com/lnbits/lnbits/actions/runs/5923472308
same as before the change

link to latest run: https://github.com/lnbits/lnbits/actions/runs/5923412325?pr=1889

screenshot-1692602840

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

Merging #1889 (f59bea5) into main (eb0b06f) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1889      +/-   ##
==========================================
- Coverage   56.12%   55.98%   -0.15%     
==========================================
  Files          48       48              
  Lines        7335     7307      -28     
==========================================
- Hits         4117     4091      -26     
+ Misses       3218     3216       -2     

see 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dni dni force-pushed the workflows branch 3 times, most recently from 95abc6a to 6a14c2c Compare August 20, 2023 21:02
@dni dni changed the title [TEST] WIP: making a proper github CI workflow [CI] improve on github workflows Aug 20, 2023
@dni dni force-pushed the workflows branch 2 times, most recently from bcbc064 to 41413a8 Compare August 21, 2023 06:41
@dni dni marked this pull request as ready for review August 21, 2023 07:35
@dni dni requested a review from callebtc August 21, 2023 07:36
@dni dni requested review from arcbtc, motorina0, talvasconcelos, jackstar12, callebtc and a team and removed request for callebtc August 21, 2023 07:36
@dni dni force-pushed the workflows branch 3 times, most recently from f59bea5 to f84fe85 Compare August 24, 2023 09:33
Copy link
Member

@arcbtc arcbtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this LGTM

.github/workflows/ci.yml Show resolved Hide resolved
@dni dni merged commit c54f48e into main Aug 24, 2023
46 checks passed
@dni dni deleted the workflows branch August 24, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants