Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fakewallet: set tag of description_hash invoice correctly #1901

Merged
merged 1 commit into from Aug 28, 2023

Conversation

callebtc
Copy link
Collaborator

When using description_hash the tag h needs to be set.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Merging #1901 (048457d) into main (b0ad47b) will increase coverage by 1.25%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1901      +/-   ##
==========================================
+ Coverage   56.36%   57.62%   +1.25%     
==========================================
  Files          49       49              
  Lines        7524     8684    +1160     
==========================================
+ Hits         4241     5004     +763     
- Misses       3283     3680     +397     
Files Changed Coverage Δ
lnbits/wallets/fake.py 74.57% <100.00%> (+0.66%) ⬆️

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dni dni requested review from jackstar12 and dni August 25, 2023 09:05
@arcbtc arcbtc self-requested a review August 28, 2023 10:02
@arcbtc arcbtc merged commit 172c277 into main Aug 28, 2023
36 checks passed
@arcbtc arcbtc deleted the wallets/fakewallet_fix_description_hash branch August 28, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants