[FEAT] add cache busting via static_url_for and settings.cache_version

[dni]

closes #1954
this PR add cache busting to /static
additionally i combined lnbits/core/static with lnbits/static, it was not necessary and added a lot of duplicate code for cache busting now you have to include all static files inside the html files with {{ static_url_for('static', 'app.css' ) }}

[codecov]

Codecov Report

Merging #1964 (d1ef472) into dev (c8147bd) will increase coverage by 0.03%.
Report is 1 commits behind head on dev.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##              dev    #1964      +/-   ##
==========================================
+ Coverage   60.60%   60.63%   +0.03%     
==========================================
  Files          55       55              
  Lines        8318     8325       +7     
==========================================
+ Hits         5041     5048       +7     
  Misses       3277     3277              

Files	Coverage Δ
lnbits/app.py	66.66% <100.00%> (+0.11%)	⬆️
lnbits/helpers.py	65.95% <100.00%> (+1.12%)	⬆️
lnbits/settings.py	90.87% <100.00%> (+0.07%)	⬆️
lnbits/core/views/generic.py	44.87% <33.33%> (+0.27%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[arcbtc]

Hi @prusnak, I added you as I was concerned this may impact nix stuff. We originally stopping static file building as nix didnt like lnbits changing its own code

[dni]

its created a lnbits/static/_digest direcotry with all the renamed files and serves them from there.

[prusnak]

We originally stopping static file building as nix didnt like lnbits changing its own code

the change does not change any code, it just creates new files - which is a good point to address for nix

its created a lnbits/static/_digest direcotry with all the renamed files and serves them from there.

this location shouldn't be used because on nix this would be read-only, maybe we should generate the files not into lnbits/static/_digest but into {LNBITS_DATA_FOLDER}/static or some other configurable location with write enabled?

[prusnak]

I am wondering whether we shouldn't just introduce static_url_for(X) which returns f"/static/{X}?v={CACHE_VERSION}" (providing we introduce CACHE_VERSION to Python as well) and not use the fastapi-static-digest magic.

[dni]

I am wondering whether we shouldn't just introduce static_url_for(X) which returns f"/static/{X}?v={CACHE_VERSION}" (providing we introduce CACHE_VERSION to Python as well) and not use the fastapi-static-digest magic.

yep, seems reasonable aswell, ill have another try

[dni]

it feels like that was a bit too easy :)

[prusnak]

I haven't tested this, but I do like this approach much more than introducing fastapi-static-digest dependency.

untested ACK

[motorina0]

• I have ran make bundle and pushed changes
• vendor.json needs to update paths
• see commit d86472c

-    "/static/vendor/moment.js",
-    "/static/vendor/underscore.js",
...

+    "vendor/moment.js",
+    "vendor/underscore.js",
...