fix: Closed channels affecting the stats #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1998 +/- ##
==========================================
+ Coverage 61.58% 61.64% +0.05%
==========================================
Files 55 55
Lines 8057 8058 +1
==========================================
+ Hits 4962 4967 +5
+ Misses 3095 3091 -4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I think only including active ones is fine |
jackstar12
approved these changes
Oct 5, 2023
prusnak
approved these changes
Oct 5, 2023
dni
approved these changes
Oct 6, 2023
motorina0
approved these changes
Oct 9, 2023
|
4 acks - merging thanks @iWarpBTC ! |
dni
pushed a commit
that referenced
this pull request
Oct 17, 2023
Co-authored-by: jackstar12 <jkranawetter05@gmail.com>
prusnak
pushed a commit
that referenced
this pull request
Oct 17, 2023
Co-authored-by: jackstar12 <jkranawetter05@gmail.com>
dni
pushed a commit
that referenced
this pull request
Oct 17, 2023
Co-authored-by: jackstar12 <jkranawetter05@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I've updated to 0.11.0, rushed the new node stats and it just doesn't seem right to me. Closed channels are being included. Here I'm offering my humble hot fix.
Maybe also inactive channels should be included in some/all of those stats? Let me know what you think.