dependency cleanup #2011
Merged
dependency cleanup #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
prusnak
commented
Oct 7, 2023
prusnak
commented
- async-timeout is not used anywhere (nor core neither extensions)
- cerberus is not used anywhere (nor core neither extensions)
- move embit and secp256k1 to end of the list
- these are not used by core
- document which extensions use them
- async-timeout is not used anywhere (nor core neither extensions) - cerberus is not used anywhere (nor core neither extensions) - move embit and secp256k1 to end of the list - these are not used by core - document which extensions use them
jackstar12
approved these changes
Oct 7, 2023
callebtc
approved these changes
Oct 7, 2023
Codecov Report
@@ Coverage Diff @@
## dev #2011 +/- ##
==========================================
- Coverage 61.62% 61.62% -0.01%
==========================================
Files 55 55
Lines 8057 8085 +28
==========================================
+ Hits 4965 4982 +17
- Misses 3092 3103 +11 see 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dni
approved these changes
Oct 7, 2023
dni
pushed a commit
that referenced
this pull request
Oct 17, 2023
- async-timeout is not used anywhere (nor core neither extensions) - cerberus is not used anywhere (nor core neither extensions) - move embit and secp256k1 to end of the list - these are not used by core - document which extensions use them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.