Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PNG logo for QR code instead of SVG logo #2028

Merged
merged 1 commit into from Oct 12, 2023
Merged

use PNG logo for QR code instead of SVG logo #2028

merged 1 commit into from Oct 12, 2023

Conversation

prusnak
Copy link
Collaborator

@prusnak prusnak commented Oct 11, 2023

SVG causes rendering issues on some browsers unfortunately (see below)

file lnbits/static/images/logos/lnbits.png is copied from docs/logos/lnbits.png

SVG logo:

image

PNG logo:

image

SVG causes rendering issues on some browsers unfortunately
@prusnak prusnak added this to the 0.11.1 milestone Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #2028 (e211744) into dev (dc7ce1e) will increase coverage by 0.02%.
Report is 2 commits behind head on dev.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #2028      +/-   ##
==========================================
+ Coverage   61.66%   61.69%   +0.02%     
==========================================
  Files          55       55              
  Lines        8061     8061              
==========================================
+ Hits         4971     4973       +2     
+ Misses       3090     3088       -2     
Files Coverage Δ
lnbits/settings.py 90.67% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dni dni requested a review from motorina0 October 12, 2023 09:31
@dni dni merged commit 6457f7b into dev Oct 12, 2023
46 checks passed
@dni dni deleted the qr-png-logo branch October 12, 2023 10:59
dni pushed a commit that referenced this pull request Oct 17, 2023
SVG causes rendering issues on some browsers unfortunately
dni added a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants