Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python-crontab for scheduler extension #2032

Merged
merged 2 commits into from Oct 16, 2023

Conversation

bitkarrot
Copy link
Contributor

@dni dni requested review from dni, prusnak and motorina0 October 14, 2023 11:18
Copy link
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to also run poetry lock --no-update so poetry.lock file is refreshed

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #2032 (2e56504) into dev (00c3b69) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2032   +/-   ##
=======================================
  Coverage   61.70%   61.70%           
=======================================
  Files          55       55           
  Lines        8068     8068           
=======================================
  Hits         4978     4978           
  Misses       3090     3090           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bitkarrot
Copy link
Contributor Author

you need to also run poetry lock --no-update so poetry.lock file is refreshed

OK I ran the above and checked in the poetry.lock file. Let me know if its correct or not.

@prusnak
Copy link
Collaborator

prusnak commented Oct 15, 2023

@bitkarrot you are running old version of poetry (1.4.2) while the poetry lock has been generated with a newer one (1.5.1). The older version added lot of unneeded stuff, so I rerun the poetry lock --no-update with a newer version and replaced the last commit in your PR branch.

@bitkarrot
Copy link
Contributor Author

Ok whoops I will update my poetry now. It auto updated to 1.6.1

Thanks for updating the file. @prusnak

@prusnak prusnak merged commit 1226d2e into lnbits:dev Oct 16, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants