add comment why CLightningWallet alias is needed #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2065 +/- ##
==========================================
- Coverage 60.63% 60.61% -0.03%
==========================================
Files 55 55
Lines 8325 8325
==========================================
- Hits 5048 5046 -2
- Misses 3277 3279 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dni
approved these changes
Oct 26, 2023
prusnak
force-pushed
the
remove-import
branch
from
031283b
to
6f9c74b
Compare
|
NACK This is intentional to keep backwards compatibility for old configs that called it |
prusnak
force-pushed
the
remove-import
branch
from
6f9c74b
to
1ecbb48
Compare
prusnak
force-pushed
the
remove-import
branch
from
1ecbb48
to
7f6f1bc
Compare
prusnak
changed the title
|
Reworked to add comment why this alias is needed. There is an extra empty line because black wants it that way and ruff does not complain. |
dni
approved these changes
Oct 30, 2023
motorina0
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an extra empty line because black wants it that way and ruff does not complain.