Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass custom extra on payment out #2089

Merged
merged 1 commit into from Nov 21, 2023
Merged

pass custom extra on payment out #2089

merged 1 commit into from Nov 21, 2023

Conversation

talvasconcelos
Copy link
Collaborator

Allow extra to get passed when making a payment.

{
  "unit": "sat",
  "out": true,
  "extra": {
      "orderId":"3l4k23j4k2l3j34",
      "tag":"FEES"
  },
  "bolt11": "lnbc10u...0p8da5"
}

on the payments will show:

{
  "paid": true,
  "preimage": "0...000",
  "details": {
    "checking_id": "ede3426...93bb8d6",
    "pending": false,
    "amount": -1000000,
    ...
    "expiry": 1699445241,
    "extra": {
      "orderId": "3l4k23j4k2l3j34",
      "tag": "FEES"
    },
    ...
  }
}

Closes #2082

@talvasconcelos talvasconcelos added bug Something isn't working feature request New feature request labels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a27b91) 60.40% compared to head (c8b0cf3) 60.59%.

❗ Current head c8b0cf3 differs from pull request most recent head 93b27b6. Consider uploading reports for the commit 93b27b6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2089      +/-   ##
==========================================
+ Coverage   60.40%   60.59%   +0.19%     
==========================================
  Files          56       55       -1     
  Lines        8438     8322     -116     
==========================================
- Hits         5097     5043      -54     
+ Misses       3341     3279      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dni dni added this to the 0.11.2 milestone Nov 21, 2023
@dni dni requested a review from arcbtc November 21, 2023 11:18
@dni dni merged commit 90c54f2 into dev Nov 21, 2023
10 checks passed
@dni dni deleted the allow_extra_on_pay branch November 21, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra and memo is not coming in trx history, while passing while paying invoice[BUG]
3 participants