New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: manage extensions navbar #2121
Conversation
create now `Manage` spacer in sidebar. and add manage extensions to it closes #2088
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2121 +/- ##
=======================================
Coverage 60.38% 60.38%
=======================================
Files 56 56
Lines 8437 8437
=======================================
Hits 5095 5095
Misses 3342 3342 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
the PR needs a
make bundle
commit -
This change does not work correctly if admin UI is disabled (
LNBITS_ADMIN_UI=false
)
Since there is no management section, there is also no manage extensions button.
We should change the logic so that management section (and manage extensions button) is always shown, regardless of whetherLNBITS_ADMIN_UI
is set to true or false.
before the change it looks like this:
i actually did that it was visible for non admins? maybe you used the bundle? |
bundled |
Steps to reproduce (2):
|
I found the culprit: lnbits/lnbits/templates/base.html Lines 264 to 267 in 3b0024b
The |
f3ba4c9
to
6fd14b1
Compare
Fixed the issue in 9084c8f followed by another commit which just does |
I discovered duplicit strings in localization related to the manage change, I also added Korean translation from #2119 which I fixed to use the new manage strings too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
create
Manage
spacer in sidebar and add manage extensions to it