-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add currency amount to lnurl/lnaddress payments #2136
Conversation
Hah, |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #2136 +/- ##
==========================================
- Coverage 59.29% 59.23% -0.06%
==========================================
Files 60 60
Lines 8942 8951 +9
==========================================
Hits 5302 5302
- Misses 3640 3649 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good
When I set EUR in the dialog once and then go to pay for another request, the unit is set to EUR again. Maybe we should reset it to But if you say that it is preferred that way, to keep the preference persistent, I am OK with that as well. Otherwise the frontend changes look nice! |
fa3aa22
to
3e11417
Compare
Resolved conflicts, rebased on top of the current |
3e11417
to
7389be5
Compare
9aeb23a
to
797498b
Compare
797498b
to
8f50bbc
Compare
@dni What is your take on this? If you want to keep it persistent, I will approve and merge. |
8f50bbc
to
19f61fd
Compare
Resolved conflicts, rebased on top of the current |
hey @prusnak! i look it at again and after i tried it i thought that when i selected it once, i probably want to keep going in that currency and not have to select it again at least for the current pageload. i dont think not reseting to sat is a problem. |
19f61fd
to
72bd601
Compare
closes #2135