Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add currency amount to lnurl/lnaddress payments #2136

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

dni
Copy link
Member

@dni dni commented Nov 30, 2023

closes #2135

@prusnak
Copy link
Collaborator

prusnak commented Nov 30, 2023

Hah, checkbundle CI check worked! 🎉

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (8eabf53) 59.29% compared to head (72bd601) 59.23%.

Files Patch % Lines
lnbits/core/views/api.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2136      +/-   ##
==========================================
- Coverage   59.29%   59.23%   -0.06%     
==========================================
  Files          60       60              
  Lines        8942     8951       +9     
==========================================
  Hits         5302     5302              
- Misses       3640     3649       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lnbits/core/templates/core/wallet.html Outdated Show resolved Hide resolved
lnbits/core/templates/core/wallet.html Outdated Show resolved Hide resolved
@dni dni requested a review from prusnak November 30, 2023 10:55
Copy link
Collaborator

@talvasconcelos talvasconcelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@prusnak
Copy link
Collaborator

prusnak commented Nov 30, 2023

When I set EUR in the dialog once and then go to pay for another request, the unit is set to EUR again. Maybe we should reset it to sat every time the dialog is open?

But if you say that it is preferred that way, to keep the preference persistent, I am OK with that as well.

Otherwise the frontend changes look nice!

@prusnak
Copy link
Collaborator

prusnak commented Dec 6, 2023

Resolved conflicts, rebased on top of the current dev.

@dni dni force-pushed the feat-fiat-lnurl branch 2 times, most recently from 9aeb23a to 797498b Compare December 12, 2023 14:09
@dni dni added this to the 0.12.0 milestone Dec 14, 2023
@prusnak
Copy link
Collaborator

prusnak commented Dec 23, 2023

When I set EUR in the dialog once and then go to pay for another request, the unit is set to EUR again. Maybe we should reset it to sat every time the dialog is open?

But if you say that it is preferred that way, to keep the preference persistent, I am OK with that as well.

@dni What is your take on this? If you want to keep it persistent, I will approve and merge.

@prusnak
Copy link
Collaborator

prusnak commented Jan 16, 2024

Resolved conflicts, rebased on top of the current dev.

@dni
Copy link
Member Author

dni commented Jan 22, 2024

hey @prusnak! i look it at again and after i tried it i thought that when i selected it once, i probably want to keep going in that currency and not have to select it again at least for the current pageload. i dont think not reseting to sat is a problem.

@prusnak prusnak merged commit c047ae6 into dev Jan 22, 2024
22 checks passed
@prusnak prusnak deleted the feat-fiat-lnurl branch January 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] make lnurl payable with a fiat amount
3 participants