feat: add group_by to fetch_page #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2140 +/- ##
==========================================
+ Coverage 58.53% 58.63% +0.09%
==========================================
Files 61 61
Lines 9187 9193 +6
==========================================
+ Hits 5378 5390 +12
+ Misses 3809 3803 -6 ☔ View full report in Codecov by Sentry. |
motorina0
reviewed
Dec 4, 2023
|
Please add some unit tests. |
dni
force-pushed
the
feat-groupby-fetchpage
branch
from
3aac26e
to
16954ab
Compare
|
Can we please have one small test for |
|
added tests |
motorina0
reviewed
Dec 20, 2023
motorina0
reviewed
Dec 20, 2023
motorina0
reviewed
Dec 20, 2023
motorina0
reviewed
Dec 20, 2023
dni
force-pushed
the
feat-groupby-fetchpage
branch
2 times, most recently
from
9594a86
to
72e08f3
Compare
prusnak
approved these changes
Jan 25, 2024
motorina0
reviewed
Feb 8, 2024
| @@ -179,16 +179,27 @@ async def fetch_page( | |||
| values: Optional[List[str]] = None, | |||
| filters: Optional[Filters] = None, | |||
| model: Optional[Type[TRowModel]] = None, | |||
| group_by: Optional[List[str]] = None, | |||
There was a problem hiding this comment.
The users need to know that they have to add an aggregator function (max, count, etc) when using group_by. Otherwise the query execution will fail.
Can this requirement be documented somewhere?
dni
force-pushed
the
feat-groupby-fetchpage
branch
from
53b636f
to
c093440
Compare
dni
force-pushed
the
feat-groupby-fetchpage
branch
from
c093440
to
d991538
Compare
motorina0
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature is required by #2139