bug: cln paymentstate check on error

[callebtc]

Payment state check should only return False if the payment 100% failed. Uncheckable entries should not enter the db in the first place, which we will be working on next.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.54%. Comparing base (6083948) to head (e01c45f).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #2151   +/-   ##
=======================================
  Coverage   58.53%   58.54%           
=======================================
  Files          61       61           
  Lines        9187     9181    -6     
=======================================
- Hits         5378     5375    -3     
+ Misses       3809     3806    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[prusnak]

CI failure: https://github.com/lnbits/lnbits/actions/runs/7099157921/job/19322647760?pr=2151

[prusnak]

Is the commit 09b91b8 that removes the time block intentional? cc @dni (author of that feature)

[dni]

i am scared, i think also the debug log when deleting was removed,and that actually saved us this time discovering the issue at all. so at least the log should be readded.

[prusnak]

i am scared, i think also the debug log when deleting was removed

It was re-added in 7dfbabf

Working

[prusnak]

Squashed and rebased