Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move webpush to its own router #2155

Merged
merged 1 commit into from Dec 6, 2023
Merged

refactor: move webpush to its own router #2155

merged 1 commit into from Dec 6, 2023

Conversation

dni
Copy link
Member

@dni dni commented Dec 5, 2023

refactor to make views/api.py cleaner

@dni dni requested review from a team, motorina0, talvasconcelos and arcbtc and removed request for a team December 5, 2023 14:57
@dni dni changed the title refactor: move webpush to it own router refactor: move webpush to its own router Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (fa49133) 60.35% compared to head (9527ee1) 60.41%.

Files Patch % Lines
lnbits/core/views/webpush_api.py 59.09% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2155      +/-   ##
==========================================
+ Coverage   60.35%   60.41%   +0.05%     
==========================================
  Files          57       58       +1     
  Lines        8466     8476      +10     
==========================================
+ Hits         5110     5121      +11     
+ Misses       3356     3355       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@prusnak prusnak added this to the 0.11.3 milestone Dec 5, 2023
refactor to make `views/api.py` cleaner
Copy link
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@prusnak prusnak merged commit 5fc472a into dev Dec 6, 2023
22 checks passed
@prusnak prusnak deleted the refactor-webpush branch December 6, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants