Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified mobile wallet #2175

Merged
merged 14 commits into from
Dec 22, 2023
Merged

Simplified mobile wallet #2175

merged 14 commits into from
Dec 22, 2023

Conversation

arcbtc
Copy link
Member

@arcbtc arcbtc commented Dec 12, 2023

Will make advanced stuff optional, but cleaned UI for mobile

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 436 lines in your changes are missing coverage. Please review.

Comparison is base (a2469ab) 60.63% compared to head (a76228c) 58.66%.
Report is 79 commits behind head on dev.

Files Patch % Lines
lnbits/core/views/auth_api.py 20.18% 174 Missing ⚠️
lnbits/core/crud.py 25.31% 59 Missing ⚠️
lnbits/wallets/alby.py 23.94% 54 Missing ⚠️
lnbits/core/views/tinyurl_api.py 31.11% 31 Missing ⚠️
lnbits/decorators.py 57.50% 17 Missing ⚠️
lnbits/core/services.py 56.25% 14 Missing ⚠️
lnbits/core/views/api.py 52.00% 12 Missing ⚠️
lnbits/core/views/webpush_api.py 59.09% 9 Missing ⚠️
lnbits/core/views/generic.py 55.55% 8 Missing ⚠️
lnbits/helpers.py 55.55% 8 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2175      +/-   ##
==========================================
- Coverage   60.63%   58.66%   -1.98%     
==========================================
  Files          55       59       +4     
  Lines        8325     8910     +585     
==========================================
+ Hits         5048     5227     +179     
- Misses       3277     3683     +406     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcbtc arcbtc changed the title WIP: Simplified mobile wallet Simplified mobile wallet Dec 20, 2023
@arcbtc
Copy link
Member Author

arcbtc commented Dec 20, 2023

gRphe8P.mp4

@prusnak
Copy link
Collaborator

prusnak commented Dec 20, 2023

gRphe8P.mp4

Love it!

@motorina0
Copy link
Collaborator

motorina0 commented Dec 20, 2023

Suggestion:

  • align center amount and Less button also when the user is on the More mode (similar to the compact mode)

image

@motorina0
Copy link
Collaborator

Suggestion 2:

  • add an Show/Hide API toggle. The API panel is important but rarely used, it should not take so much screen space.

image

@motorina0
Copy link
Collaborator

Suggestion 3:

  • nitpick: transition animation between More/Less (no idea how the CSS would look like)

@motorina0
Copy link
Collaborator

Suggestion 4:

  • this is likely the second most important screen (on mobile)
  • maybe some fields should only be shown on a More/Less basis

image

@arcbtc
Copy link
Member Author

arcbtc commented Dec 21, 2023

Added last transaction as well

2023-12-21.00-04-14.mp4

@arcbtc
Copy link
Member Author

arcbtc commented Dec 21, 2023

Suggestion 2:

* add an `Show/Hide API` toggle. The API panel is important but rarely used, it should not take so much screen space.

image

Thought about it as well, but I kinda like having this stuff, its where you set the fiat currency and can scan the wallet link. People on mobile need to be able to access.

@motorina0
Copy link
Collaborator

Maybe the wallet name (of the current wallet) should be visible somewhere (on mobile).

@arcbtc
Copy link
Member Author

arcbtc commented Dec 21, 2023

Maybe the wallet name (of the current wallet) should be visible somewhere (on mobile).

Its in "more"

Copy link
Collaborator

@talvasconcelos talvasconcelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah!

@prusnak prusnak merged commit e8c9304 into dev Dec 22, 2023
22 checks passed
@prusnak prusnak deleted the mobilewallet branch December 22, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants