Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login polish #2180

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Login polish #2180

merged 3 commits into from
Dec 14, 2023

Conversation

motorina0
Copy link
Collaborator

@motorina0 motorina0 commented Dec 14, 2023

  • add icons to User ID actions
    image

  • set samesite="none" for flag cookie (required by iframe stuff

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (bb918a8) 58.58% compared to head (21bd7a2) 59.29%.

Files Patch % Lines
lnbits/core/views/auth_api.py 0.00% 2 Missing ⚠️
lnbits/app.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2180      +/-   ##
==========================================
+ Coverage   58.58%   59.29%   +0.71%     
==========================================
  Files          59       59              
  Lines        8864     8864              
==========================================
+ Hits         5193     5256      +63     
+ Misses       3671     3608      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dni dni self-requested a review December 14, 2023 12:38
@dni dni added this to the 0.12.0 milestone Dec 14, 2023
@dni dni merged commit db72953 into dev Dec 14, 2023
22 checks passed
@dni dni deleted the login_polish branch December 14, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants