fix: urls for js libs on print.html #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes lnbits/withdraw#22 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2185 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 59 59
Lines 8864 8864
=======================================
Hits 5255 5255
Misses 3609 3609 ☔ View full report in Codecov by Sentry. |
prusnak
requested changes
Dec 17, 2023
There was a problem hiding this comment.
I think we also need to fix the CSS:
diff --git a/lnbits/templates/print.html b/lnbits/templates/print.html
index ef6beb4a..4fde0878 100644
--- a/lnbits/templates/print.html
+++ b/lnbits/templates/print.html
@@ -3,7 +3,7 @@
<html lang="en">
<head>
{% for url in INCLUDED_CSS %}
- <link rel="stylesheet" type="text/css" href="{{ url }}" />
+ <link rel="stylesheet" type="text/css" href="{{ static_url_for('static', url) }}" />
{% endfor %}
<style>
@page {
prusnak
force-pushed
the
fix_print_html_js_urls
branch
from
fab648d
to
07c01ab
Compare
prusnak
reviewed
Dec 17, 2023
prusnak
approved these changes
Dec 17, 2023
dni
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes, for example, printing LNURLw vouchers.