Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: position of method invocation #2188

Merged
merged 2 commits into from
Dec 20, 2023
Merged

fix: position of method invocation #2188

merged 2 commits into from
Dec 20, 2023

Conversation

motorina0
Copy link
Collaborator

@motorina0 motorina0 commented Dec 20, 2023

By mistake the call to await this.checkUsrInUrl() was placed inside the if (window.extensions) { conditional block.

This PR moves it outside of it.

@motorina0 motorina0 changed the title Fix check user position fix: position of method invocation Dec 20, 2023
@motorina0 motorina0 marked this pull request as ready for review December 20, 2023 12:55
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (165d749) 59.29% compared to head (084b423) 59.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2188   +/-   ##
=======================================
  Coverage   59.29%   59.29%           
=======================================
  Files          59       59           
  Lines        8871     8871           
=======================================
  Hits         5260     5260           
  Misses       3611     3611           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

checkbundle CI check passes ✅

@arcbtc arcbtc merged commit 81b70ac into dev Dec 20, 2023
22 checks passed
@arcbtc arcbtc deleted the fix_check_user_position branch December 20, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants