refactor __init__ functions of Wallets (funding sources) #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
prusnak
commented
Dec 24, 2023
prusnak
commented
- better error messages when a conf variable is not provided
- unify approaches among different source files
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #2193 +/- ##
==========================================
- Coverage 59.38% 59.27% -0.12%
==========================================
Files 60 60
Lines 8925 8942 +17
==========================================
Hits 5300 5300
- Misses 3625 3642 +17 ☔ View full report in Codecov by Sentry. |
prusnak
force-pushed
the
refactor-wallets-init
branch
from
b0c1a6f
to
0f10abd
Compare
prusnak
force-pushed
the
refactor-wallets-init
branch
from
0f10abd
to
67c007a
Compare
prusnak
force-pushed
the
refactor-wallets-init
branch
from
a922bbe
to
397e963
Compare
dni
approved these changes
Dec 28, 2023
prusnak
force-pushed
the
refactor-wallets-init
branch
from
397e963
to
fa9f3a6
Compare
prusnak
force-pushed
the
refactor-wallets-init
branch
from
fa9f3a6
to
4933fa1
Compare
jackstar12
approved these changes
Jan 22, 2024
- better error messages when a conf variable is not provided - unify approaches among different source files
prusnak
force-pushed
the
refactor-wallets-init
branch
from
4933fa1
to
1e4714e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.