Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UI configs to profile #2201

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Move UI configs to profile #2201

merged 4 commits into from
Jan 15, 2024

Conversation

motorina0
Copy link
Collaborator

@motorina0 motorina0 commented Jan 10, 2024

Summary

Move the UI config buttons from the app header to the User Profile page.
Only the User Icon is left on the app header. This change leaves more room for important messages to be displayed in the header and makes the UI look better on mobile.

Note: changeColor method is also kept in base.js (used for initalisation)

image

move_ui_buttons.mov

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 433 lines in your changes are missing coverage. Please review.

Comparison is base (a2469ab) 60.63% compared to head (f0b8c83) 59.36%.
Report is 86 commits behind head on dev.

Files Patch % Lines
lnbits/core/views/auth_api.py 20.18% 174 Missing ⚠️
lnbits/core/crud.py 25.31% 59 Missing ⚠️
lnbits/wallets/alby.py 23.94% 54 Missing ⚠️
lnbits/core/views/tinyurl_api.py 31.11% 31 Missing ⚠️
lnbits/decorators.py 57.50% 17 Missing ⚠️
lnbits/core/services.py 56.25% 14 Missing ⚠️
lnbits/core/views/api.py 52.00% 12 Missing ⚠️
lnbits/core/views/webpush_api.py 59.09% 9 Missing ⚠️
lnbits/core/views/generic.py 55.55% 8 Missing ⚠️
lnbits/helpers.py 55.55% 8 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2201      +/-   ##
==========================================
- Coverage   60.63%   59.36%   -1.28%     
==========================================
  Files          55       59       +4     
  Lines        8325     8908     +583     
==========================================
+ Hits         5048     5288     +240     
- Misses       3277     3620     +343     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0 motorina0 marked this pull request as ready for review January 10, 2024 13:03
@motorina0 motorina0 changed the title Move configs to profile Move UI configs to profile Jan 10, 2024
@motorina0 motorina0 requested a review from arcbtc January 10, 2024 13:18
@motorina0 motorina0 merged commit 4cea06c into dev Jan 15, 2024
22 checks passed
@motorina0 motorina0 deleted the move_configs_to_profile branch January 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants