feat: improve PWA configuration #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- PWA Errors: --- - fix logo size - add shortcut icon - add maskable icons - add desktop and phone screenshots (wide and narrow)
Images for PWA, tested, everything is working fine.
[+] Please put images to lnbits/static/images where other images are. [+] Please install optipng and run tools/optipng.sh script to optimize PNGs
…ized sizes, reduced file size, and cleaned metadata. +maskable icons Updated screenshots for desktop and phone with a classic theme, optimized sizes, reduced file size, and cleaned metadata. +maskable icons Apologies for the mistake.
…o empty file in the tools directory (maybe because of chmod +x optipng.sh)
|
black in CI is failing please run |
|
Done.
|
prusnak
approved these changes
Jan 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2214 +/- ##
=======================================
Coverage 59.38% 59.38%
=======================================
Files 60 60
Lines 8925 8925
=======================================
Hits 5300 5300
Misses 3625 3625 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2199