alby: fix balance reporting and error handling + opennode: fix error handling #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #2221 +/- ##
==========================================
- Coverage 59.23% 59.21% -0.02%
==========================================
Files 60 60
Lines 8991 8994 +3
==========================================
Hits 5326 5326
- Misses 3665 3668 +3 ☔ View full report in Codecov by Sentry. |
dni
approved these changes
Jan 30, 2024
|
Let's not postpone to another milestone. The Alby integration is now unusable so it does not make sense to keep it broken for 0.12.0. Can we have another review @motorina0 @arcbtc plz? |
motorina0
reviewed
Feb 6, 2024
|
|
||
| return StatusResponse(None, data) | ||
| data = r.json() | ||
| assert data["unit"] == "sat" |
There was a problem hiding this comment.
nitpick:
Suggested change
| assert data["unit"] == "sat" | |
| assert data["unit"] == "sat", f"Expected unit 'sat', but was '{data["unit"]}'" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @bitkarrot for testing