-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet limits: max balance, daily max withdraw, transactions per sec #2223
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #2223 +/- ##
==========================================
- Coverage 59.26% 59.25% -0.02%
==========================================
Files 60 60
Lines 8992 9026 +34
==========================================
+ Hits 5329 5348 +19
- Misses 3663 3678 +15 ☔ View full report in Codecov by Sentry. |
b1c2e67
to
cf0eaf1
Compare
@arcbtc wanted to implement that in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFG!
088ca73
to
cb70edc
Compare
New
.env
variableLNBITS_MAX_WALLET_BALANCE_SAT
can limit the maximum balance for each wallet and throw an error if the wallet attempts to create a new invoice.Example:
LNBITS_MAX_WALLET_BALANCE_SAT=1000000
=============UPDATE==============
Legacy banks, exchanges, anything dealing with money have wallet limits, so adding a few more optional wallet limits seems like a good security tool.
Added daily max limit and transactions per second.