-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes annoying qr popup on parsing LNURL withdraw receive in wallet #2230
Conversation
i cannot really tell what the issue is, can you provide a screenshot or something what the problem is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still going to approve it, despite missing some context, seems simple enough
@@ -569,7 +569,10 @@ <h6 class="text-subtitle1 q-mt-none q-mb-sm"> | |||
></q-spinner> | |||
</q-form> | |||
</q-card> | |||
<q-card v-else class="q-pa-lg q-pt-xl lnbits__dialog-card"> | |||
<q-card | |||
v-else-if="receive.paymentReq && receive.lnurl == null" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the corresponding v-if
is:
<q-card
v-if="!receive.paymentReq"
so receive.paymentReq
is not required in this condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats for the parse card in the dialogue
@@ -569,7 +569,10 @@ <h6 class="text-subtitle1 q-mt-none q-mb-sm"> | |||
></q-spinner> | |||
</q-form> | |||
</q-card> | |||
<q-card v-else class="q-pa-lg q-pt-xl lnbits__dialog-card"> | |||
<q-card | |||
v-else-if="receive.paymentReq && receive.lnurl == null" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v-else-if="receive.paymentReq && receive.lnurl == null" | |
v-else-if="receive.lnurl == null" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if this condition is false: receive.lnurl == null
(ie. receive.lnurl != null
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The invoice QR code card in the dialogue should only fire creating an invoice, not when an invoice is parsed out of an lnurl-withdraw.
Making false would mean the opposite, and would e even worse than before.
No description provided.