feat: unique invoice listeners for extensions #2250
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the
register_invoice_listener
to use a non unique key so you its not possible to have a listeners running twice and throw a warning when trying to.we should discourage use of
get_current_extension_name
its not needed, easy enough for the extension dev to pass the extension name or whatever he wants his listener to be named.@talvasconcelos some extension still don't use a name, but they should! can you check that? also they should not use
get_current_extension_name()
anymore