Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves payment reactions #2251

Merged
merged 21 commits into from
Feb 12, 2024
Merged

Improves payment reactions #2251

merged 21 commits into from
Feb 12, 2024

Conversation

arcbtc
Copy link
Member

@arcbtc arcbtc commented Feb 9, 2024

  • only triggers on incoming
  • choice between different reactions
  • easy to add to extensions, all that's needed frontend is eventReactionWebocket(<wallet_id or some_other_id>), if not using walllet_id in tasks.py, or wherever you want to trigger the reaction from in backend, add await websocketUpdater(some_other_id, data)

image

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (62dec11) 59.26% compared to head (775802b) 59.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2251      +/-   ##
==========================================
- Coverage   59.26%   59.25%   -0.02%     
==========================================
  Files          60       60              
  Lines        9026     9026              
==========================================
- Hits         5349     5348       -1     
- Misses       3677     3678       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@motorina0

This comment was marked as resolved.

lnbits/static/js/base.js Outdated Show resolved Hide resolved
arcbtc and others added 3 commits February 9, 2024 14:27
Co-authored-by: Vlad Stan <stan.v.vlad@gmail.com>
@arcbtc arcbtc requested a review from motorina0 February 9, 2024 14:41
@motorina0
Copy link
Collaborator

  • why is package-lock.json updated, but package.json not
  • package-lock.json now has versinon: 1, previously it was version: 3

@prusnak prusnak added this to the 0.12.1 milestone Feb 11, 2024
@arcbtc arcbtc merged commit 98338ff into dev Feb 12, 2024
22 checks passed
@arcbtc arcbtc deleted the websocketeverything branch February 12, 2024 10:48
@dni dni modified the milestones: 0.12.2, 0.12.1 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants