Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Blink Funding Source - GraphQL API integration #2270

Closed
wants to merge 34 commits into from

Conversation

bitkarrot
Copy link
Contributor

Blink Wallet API Integration - WIP

Note: the test script is not in proper pytest format, will convert after I get the main part working.

Referencing #2227

@bitkarrot
Copy link
Contributor Author

Note Please don't edit this branch until it is ready for review. thanks.

@bitkarrot
Copy link
Contributor Author

Waiting for Galoy/Blink Devs to write in a new method to their GraphQL endpoint in order to complete this integration.
Will take a few days.

cc: @openoms

@prusnak prusnak linked an issue Feb 23, 2024 that may be closed by this pull request
@bitkarrot bitkarrot marked this pull request as ready for review March 18, 2024 08:14
@bitkarrot
Copy link
Contributor Author

Not sure if this is the right way to do the unit test, but I tried as a first pass.

Also graphql is really long seems to break the formatter.

@bitkarrot
Copy link
Contributor Author

If someone can please run and test, that'd be appreciated.

cc: @openoms, @pretyflaco

@bitkarrot
Copy link
Contributor Author

I will fix the conflicts in the am...

@openoms
Copy link

openoms commented Mar 21, 2024

Thank you for this great PR @bitkarrot, it looks very close to completion!

I've been setting up a server running this branch and tested successfully:

  • adding a Blink API key and switching funding source
  • send over LN
  • receive over LN
  • send intraledger (Blink to Blink)
  • receive intraledger

Extensions tried:

  • LNURLw vouchers works
  • Bolt card works
  • TPoS works

One thing I noticed so far that if I just simply top up a wallet with the RECEIVE button on the bottom left the payment does not get picked up live. Need to close the invoice and refresh the screen to see the balance change.

Tested this with switching the funding source to another LNbits and on another instance backed by CLN - there the payments are picked up live.

Note the TPOS is getting the instant feedback with the green checkmark.

Could this be solved?

Please anyone else testing, this is the best time for any feedback.

@bitkarrot bitkarrot changed the title Blink GraphQL API integration (WIP) feat: Blink Funding Source - GraphQL API integration (WIP) Mar 26, 2024
@bitkarrot bitkarrot changed the title feat: Blink Funding Source - GraphQL API integration (WIP) feat: Blink Funding Source - GraphQL API integration Mar 26, 2024
@bitkarrot
Copy link
Contributor Author

@openoms i'm looking into how we can get the websocket part going for the receive issue.

@bitkarrot
Copy link
Contributor Author

putting websocket method on hold.

requesting review from @prusnak and @dni when possible.

cc: @openoms

@bitkarrot
Copy link
Contributor Author

Updated branch to resolve conflicts and make format.

CI is failing on i18n files, appears unrelated to branch

@prusnak
Copy link
Collaborator

prusnak commented May 4, 2024

I rebased and squashed this PR into a new PR #2477

I suggest we continue there

@prusnak
Copy link
Collaborator

prusnak commented May 20, 2024

Closed in favor of #2477

@prusnak prusnak closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Blink as a funding source
3 participants