feat: add node url to api keys & docs #2283
Conversation
| @@ -90,6 +90,7 @@ new Vue({ | |||
| mixins: [windowMixin], | |||
| data: function () { | |||
| return { | |||
| origin: window.location.origin, | |||
There was a problem hiding this comment.
I don't think this is correct - when LNbits is deployed to https://foobar.example/lnbits then window.location.origin returns just https://foobar.example and not https://foobar.example/lnbits - or is this type of deployment unsupported?
However, the only other "correct" option would be to get settings.lnbits_baseurl from python to javascript, but since we do not use this variable in any meaningful way, I guess that using origin makes more sense (until we fix how lnbits_baseurl is used).
So let's do it the proposed way for now.
Yes, I just did that in 72572b5 (which also added some other new strings) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2283 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 60 60
Lines 9026 9026
=======================================
Hits 5351 5351
Misses 3675 3675 ☔ View full report in Codecov by Sentry. |
closes #2277
@prusnak what would you say would be the easiest way to change that label for all languages. just remove the key for all languages and run your script?